[revised, tests added] added support for buffer / memoryview data #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peci1
force-pushed
the
fix-buffer
branch
2 times, most recently
from
be3e1dd
to
ff15d30
Compare
|
There is probably also a bug in the tests themselves: genpy/test/test_genpy_message.py Lines 368 to 369 in d329672 In Python3, strings cannot be packed by the |
|
According to https://peps.python.org/pep-0688/ , in Python < 3.12, there is really no better way to test buffer protocol support than the try/except... |
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I iterated on #108 to add support for direct serialization of buffer protocol objects.
Closes #107.
I've added as much tests as I could imagine.
The generated code is a bit ugly because I found that if you pass a string to
uint8[]field, its length is not checked. I wanted to explicitly make sure this behavior is kept for strings, but it did not occur good to me to keep it for the buffer protocol objects.One of the use-cases I have for this feature is incrementally building a
PointCloud2. If you represent the data field asbytearray, you get all the nicestd::vector<>-like behavior (amortizedO(1)append). And if thisbytearraycan be directly used in serialization, then the only copy you need to make is the serialization itself. Currently, I need to callbytes(my_bytearray_data), which makes a copy, and then pass this copy to the serialization. So that's an unnecessary copy of a whole lot of data (in the case of pointclouds).Struct.packpads with zeros if a shorter string is given, or cuts the string it if is longer: